From e0efd067e47e964bd60ad34ab331497867b49fd4 Mon Sep 17 00:00:00 2001 From: Paolo Borelli Date: Sun, 5 Dec 2010 12:30:28 +0100 Subject: [PATCH] Avoid memory corruption in the color_properties hashtable. --- gtk/gtkmodifierstyle.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/gtk/gtkmodifierstyle.c b/gtk/gtkmodifierstyle.c index 48a4f21f6e..2cbee61b39 100644 --- a/gtk/gtkmodifierstyle.c +++ b/gtk/gtkmodifierstyle.c @@ -282,11 +282,15 @@ gtk_modifier_style_set_color_property (GtkModifierStyle *style, } if (color) - g_hash_table_insert (priv->color_properties, str, - gdk_rgba_copy (color)); + { + g_hash_table_insert (priv->color_properties, str, + gdk_rgba_copy (color)); + } else - g_hash_table_remove (priv->color_properties, str); + { + g_hash_table_remove (priv->color_properties, str); + g_free (str); + } g_signal_emit (style, signals[CHANGED], 0); - g_free (str); } -- 2.30.2